That's a great idea if you have the room for all those containers. I have my stash in the closet in a few of those hanging sweater holders. I thought of this idea over a year ago, and then I saw the same kinds of containers used as yarn holders (but, of course, they were now called some new fancy name involving yarn and they were much more expensive).
Although my yarn is now organized, it does have its down side: my husband can see exactly how much yarn I have and can now say (and does), "You don't need anymore yarn."
Good luck in your organizing venture!